Make the crate #![no_std]#79
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 99.39% 99.40%
=======================================
Files 7 7
Lines 666 672 +6
=======================================
+ Hits 662 668 +6
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FreezyLemon
force-pushed
the
experiment-no-std
branch
from
687eacd to
907ea33
Compare
FreezyLemon
force-pushed
the
experiment-no-std
branch
from
907ea33 to
3884f06
Compare
Member
|
We probably shouldn't have been using println for tests in the first place tbh I'll thoroughly review this in the morning and likely merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://effective-rust.com/no-std.html says:
Code changes are minimal, we don't need a
stdfeature because nothing will be disabled without it.allocis definitely required for Frame/Plane/AlignedData but that's still a smaller hurdle than the entire standard library.printlnis now off the table for tests but that's not really a big limitation IMHO.